Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty object instead of array #929

Merged
merged 2 commits into from Aug 27, 2018
Merged

Return empty object instead of array #929

merged 2 commits into from Aug 27, 2018

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Aug 24, 2018

Proposed changes

Return an empty object to match the type of walletsByAddress.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Lint and unit tests pass locally with my changes

@codecov-io
Copy link

Codecov Report

Merging #929 into develop will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #929   +/-   ##
========================================
  Coverage    51.65%   51.65%           
========================================
  Files          432      432           
  Lines         7200     7200           
  Branches       924      924           
========================================
  Hits          3719     3719           
  Misses        3049     3049           
  Partials       432      432
Impacted Files Coverage Δ
packages/core-database-sequelize/lib/connection.js 73.41% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391dcab...24965c0. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Aug 26, 2018

Codecov Report

Merging #929 into develop will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #929      +/-   ##
===========================================
- Coverage    51.65%   51.62%   -0.03%     
===========================================
  Files          432      432              
  Lines         7200     7200              
  Branches       924      924              
===========================================
- Hits          3719     3717       -2     
- Misses        3049     3050       +1     
- Partials       432      433       +1
Impacted Files Coverage Δ
packages/core-database-sequelize/lib/connection.js 73.41% <50%> (ø) ⬆️
packages/crypto/lib/models/transaction.js 61.76% <0%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7a264...7540a5b. Read the comment docs.

@faustbrian faustbrian merged commit c2d882c into ArkEcosystem:develop Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants