Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GTest #131

Merged
merged 10 commits into from
Aug 20, 2019
Merged

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Aug 19, 2019

Move from AUnit to googletest

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Aug 19, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Medium Less than 256 lines changed. label Aug 19, 2019
@ghost
Copy link

ghost commented Aug 19, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ciband ciband changed the title [WIP] Migrate to GTest Migrate to GTest Aug 20, 2019
@sleepdefic1t
Copy link
Contributor

sleepdefic1t commented Aug 20, 2019

@ciband
I’ve got a potential fix for the failing PIO in #121

utils/json.h

Remove the line that disables Arduino String.

#define ARDUINOJSON_ENABLE_ARDUINO_STRING 0 // disable 'String'

@sleepdefic1t
Copy link
Contributor

Well, that fixed some of it 🤷‍♂️

GTest just won’t make it easy.

@sleepdefic1t
Copy link
Contributor

Okay, @ciband
I think I've got it.

I ran pio run from the test dir, and saw that googletest wasn't actually being saved anywhere..

So, from test/platformio.ini, I changed lib_deps to explicitly use v1.8.1.

i.e. googletest >> googletest@1.8.1

Memory Usage -> http://bit.ly/pio-memory-usage
DATA:    [=         ]   7.3% (used 23916 bytes from 327680 bytes)
PROGRAM: [======    ]  59.2% (used 776301 bytes from 1310720 bytes)
esptool.py v2.6
================================================================= [SUCCESS] Took 31.54 seconds =================================================================

test/platformio.ini Outdated Show resolved Hide resolved
Added explicit googletest version for platformIO to fix CI
@ciband
Copy link
Contributor Author

ciband commented Aug 20, 2019

@sleepdefic1t thanks for the debugging help. I was going to get to it, you just beat me to it. Looks like that did it.

@codecov-io
Copy link

Codecov Report

Merging #131 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #131   +/-   ##
========================================
  Coverage    91.82%   91.82%           
========================================
  Files           33       33           
  Lines          856      856           
========================================
  Hits           786      786           
  Misses          70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4469607...3e15819. Read the comment docs.

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Aug 20, 2019
@ghost
Copy link

ghost commented Aug 20, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 93022a8 into ArkEcosystemArchive:develop Aug 20, 2019
@ghost
Copy link

ghost commented Aug 20, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Aug 20, 2019
@ghost
Copy link

ghost commented Aug 20, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Medium Less than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants