-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GTest #131
Migrate to GTest #131
Conversation
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Your pull request doesn't follow our contribution guidelines. Please review and correct it. |
Well, that fixed some of it 🤷♂️ GTest just won’t make it easy. |
Okay, @ciband I ran So, from
Memory Usage -> http://bit.ly/pio-memory-usage
DATA: [= ] 7.3% (used 23916 bytes from 327680 bytes)
PROGRAM: [====== ] 59.2% (used 776301 bytes from 1310720 bytes)
esptool.py v2.6
================================================================= [SUCCESS] Took 31.54 seconds ================================================================= |
Added explicit googletest version for platformIO to fix CI
@sleepdefic1t thanks for the debugging help. I was going to get to it, you just beat me to it. Looks like that did it. |
Codecov Report
@@ Coverage Diff @@
## develop #131 +/- ##
========================================
Coverage 91.82% 91.82%
========================================
Files 33 33
Lines 856 856
========================================
Hits 786 786
Misses 70 70 Continue to review full report at Codecov.
|
A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
Move from AUnit to googletest
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
develop
branch, not themaster
branchIf adding a new feature, the PR's description includes: