Vote banner doesn't update

[zillionn]

[ghost]

@zillionn Thanks for opening this issue, a maintainer will get back to you shortly!

[ghost]

@alexbarnsley @j-a-m-l @luciorubeens - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[dated]

I can probably add this to #1027

[dated]

The problem I see here is that the delegate list gets updated only on profile and network change. The naive approach would be to fetch the voted delegate through the API instead of the store, but I'd rather see a proper synchronization of the delegates.

[j-a-m-l]

@dated I've though about this issue too:

• Delegates data should be accessed through the store.
• Delegate data should be requested on the Synchronizer only to avoid duplicating code.
• The synchronization is disabled to avoid making lots of requests just checking all the delegates.

My proposal would be enabling the synchronization again, but it should be done better:

• On delegates page:
  • Synchronize with focus and check the current page only.
  • Try to infer the position (and page) of the current voted delegate and fetch it in case is not on the current page.
• During the entire session:
  • Fetch the non-visible pages of delegates with a low frequency (every 5-15 minutes) to collect their names.
• When a new transaction is received that registered a delegate, fetch the last page.

Apart from that, we may need adding a new endpoint to core to get only addresses and usernames (more than 100 in 1 request) to avoid requesting 10 pages just to know the usernames.

[zillionn]

Btw the delegates list is correct, the banner Rank: 44 is wrong.

[dated]

Yea, the delegates get fetched from the API, the voted delegate is looked up in the store which holds outdated data.

[faustbrian]

Closing this as it will be soon resolved in v3.

[ghost]

This issue has been closed. If you wish to re-open it please provide additional information.