Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Wallet forgets custom peers- repair that and also implement multiple custom peers #1207

Closed
doubled1c3 opened this issue Apr 24, 2019 · 11 comments
Labels
Type: Feature The issue is a request for new functionality.

Comments

@doubled1c3
Copy link

Problem

I introduce a custom peer to the desktop wallet, but if the peer hiccups or fails to connect, the peer autoforgets itself and I have to re-enter ip and port info every time. I also can't have a saved list of custom peers that I "like" or manage myself.

So, I would like an option in the settings list for "persistent custom peer" on/off, that does not autodisconnect and autoreconnect to standard peer if custom peer is temporarily wonky.

I would also like the ability to manage a list of custom peers that I can label (name) and hotswap between as needed. This custom peer list would be unique per network.

@ghost
Copy link

ghost commented Apr 24, 2019

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@j-a-m-l j-a-m-l added the Type: Feature The issue is a request for new functionality. label Apr 25, 2019
@doubled1c3
Copy link
Author

@j-a-m-l I'll pay ARK to the person who implements this, desperately need

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Apr 26, 2019

I'm not sure when we would be able to implement something like this, what's your most pressing use case? I mean, why do you need this feature in your daily routine?

Depending on that, we would have different possibilities.

@doubled1c3
Copy link
Author

My daily routine involves performing some light maintenance on my relay which breaks the connection with my wallet, then experiencing a slow wallet until realizing it reconnected to a random peer with slow latency, and I have to go look up the IP of the custom peer every time because the wallet doesn't remember.

Honestly I'd be happy with "Persistent Custom Peer" switch and nothing else, but I came up with some other enhancements for fun.

In short, when implementing a custom peer I expect the wallet to:

  1. Allow me to decide to force the wallet to never ever drop those peer credentials even if it loses connection momentarily

  2. Allow me to tell the wallet it's ok to drop the peer if it loses connection and reconnect to a random peer, but not make me have to type stuff in again just to reconnect to custom (saved custom peer list)

Hopefully this helps?

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Apr 26, 2019

Yes, it helps. Thanks for the detailed description.

I think that we could implement something to achieve it in the next weeks. Maybe replacing the current "custom peer" button to open a new modal window with a list of custom peers and allow editing each one (host, port) but also allow labeling them.
We could also include 1 field per peer to include it inside the list of "persistent custom peers", which could be enabled using a switch button in the menu.

What do you think @doubled1c3?

@doubled1c3
Copy link
Author

Yes that would be perfections!! The persistent peer switch would be a singular choice where only one in the list could be persistent, so it could be 0 persistent or choose 1. Having 2 persistent peers would be impossible because it would just stay persistent on one of them anyway.

So, it sounds like in the modal, the persistent peer variable would be a dropdown (combo box) where you could choose no persistent peer or one of the ones in your custom list.

@stale
Copy link

Stale bot commented Jul 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale Stale bot added the Status: Stale The pull request is in need of updates but there has not been a sufficient response. label Jul 22, 2019
@doubled1c3
Copy link
Author

Bump

@stale Stale bot removed the Status: Stale The pull request is in need of updates but there has not been a sufficient response. label Jul 22, 2019
@doubled1c3
Copy link
Author

@alexbarnsley There is a tier0 relating to this now, so I think this issue can be closed then?

@alexbarnsley
Copy link
Member

Ah I thought I closed them all, I know I closed some. Thanks @doubled1c3

@ghost
Copy link

ghost commented Aug 15, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

No branches or pull requests

3 participants