Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

touch bar support #1457

Closed
alessiodf opened this issue Sep 13, 2019 · 9 comments
Closed

touch bar support #1457

alessiodf opened this issue Sep 13, 2019 · 9 comments
Labels
Type: Feature The issue is a request for new functionality.

Comments

@alessiodf
Copy link
Contributor

It would be nice if the wallet could utilise the Touch Bar in newer MacBook Pro models to carry out certain functions or to aid navigation within the desktop wallet. Electron supports the Touch Bar so from a technical perspective I think it's doable, and there is a Touch Bar Simulator to help with development if you don't have a Touch Bar equipped machine available.

I have a Touch Bar equipped model so would be happy to help if I can. If you are willing to implement this and require my assistance or help with testing then please reach out to me via the usual channels.

@ghost
Copy link

ghost commented Sep 13, 2019

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@fix
Copy link

fix commented Sep 16, 2019

can you clarify a few use cases? On my side i can for instance see:

  • slider to adjust fees
  • quickly switch profile
  • quickly select the right word when entering the passphrase (words being filtered as we type)
  • refresh account

On the overall something that make UX slightly more confortable.

@alessiodf
Copy link
Contributor Author

All of these are very good suggestions. For example also:

When viewing the homepage there could be buttons for actions such as "create wallet" and "import wallet" and tabs to quickly jump to any of the imported wallets.
Inside a wallet there could be buttons for "Send" "Delete wallet" "{Vote|Unvote}" "Sign Message"
When sending a transaction there could be a fee slider with "Send" and "Cancel"
On the plugins page there could be buttons for "Discover" "Open" "Reload"

And for "fun" when creating a wallet maybe you could invite the user to scrub along the touch bar in a random pattern to generate entropy :-)

@stale
Copy link

stale bot commented Oct 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale The pull request is in need of updates but there has not been a sufficient response. label Oct 16, 2019
@stale stale bot closed this as completed Oct 23, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

@ghost ghost removed the Status: Stale The pull request is in need of updates but there has not been a sufficient response. label Oct 23, 2019
@alexbarnsley
Copy link
Member

I'll keep this open but it's not something high on our list

@alexbarnsley alexbarnsley reopened this Oct 23, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

This issue has now been re-opened. If applicable please provide additional information as requested by one of the reviewers.

@alexbarnsley alexbarnsley added the Type: Feature The issue is a request for new functionality. label Oct 23, 2019
@samharperpittam samharperpittam added this to the 3.0.0 milestone May 26, 2020
@faustbrian faustbrian removed this from the 3.0.0 milestone Aug 10, 2020
@faustbrian
Copy link
Contributor

Closing this for now but feel free to submit a PR against the next major release. We'll revisit this if there suddenly is a high demand for this feature.

@ghost
Copy link

ghost commented Aug 10, 2020

This issue has been closed. If you wish to re-open it please provide additional information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

No branches or pull requests

5 participants