Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

plugins: expose native crypto library #1488

Closed
alessiodf opened this issue Sep 29, 2019 · 6 comments
Closed

plugins: expose native crypto library #1488

alessiodf opened this issue Sep 29, 2019 · 6 comments
Labels
Type: Feature The issue is a request for new functionality.

Comments

@alessiodf
Copy link
Contributor

It would be very useful if the native crypto library could be exposed in the plugins sandbox.

One particular use case is that it would allow plugins to generate HMAC access tokens which are required for many external APIs. I think the library is safe enough to not require any permissions and all its functions could be exposed e.g. via walletApi.crypto since none of them appear to be potentially nefarious and all have legitimate use cases within plugins.

@ghost
Copy link

ghost commented Sep 29, 2019

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@alexbarnsley
Copy link
Member

This will need investigating I think. I want to prevent things such as making the OS unresponsive due to intensive hashing which uses up all the machine's resources

@alexbarnsley alexbarnsley added Status: Needs Investigation The issue needs more investigation before it can be verified and resolved. Type: Feature The issue is a request for new functionality. labels Oct 23, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

This issue or pull request needs further investigation. Please wait for further information, thank you.

@alessiodf
Copy link
Contributor Author

while (true) {} would achieve the same effect so I don't think this would do anything that the user couldn't already do if they wanted to lock things up.

@faustbrian
Copy link
Contributor

Will be addressed in the 3.0 release.

@ghost
Copy link

ghost commented Sep 1, 2020

This issue has been closed. If you wish to re-open it please provide additional information.

@ghost ghost removed the Status: Needs Investigation The issue needs more investigation before it can be verified and resolved. label Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

No branches or pull requests

3 participants