Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Display correct Ledger confirmation detail when sending a transaction. #1678

Closed
samharperpittam opened this issue Feb 18, 2020 · 2 comments
Closed
Assignees
Labels
Status: Needs Investigation The issue needs more investigation before it can be verified and resolved.
Milestone

Comments

@samharperpittam
Copy link
Contributor

When a user sends a transaction with their Ledger, such as vote/unvote, they need to confirm the pubkey of the delegate they are voting for on their Ledger device. However, the pubkey of the delegate they are voting for is not displayed within the wallet.

I believe it would be better practice to display all information that a user needs to confirm on their Ledger within the Desktop Wallet so the user can confirm the transaction with confidence. Currently, unless they look up details by leaving the Desktop Wallet, then they are almost confirming blindly.

This logic needs to be applied to all transaction types, not just vote/unvote.

Expected Behavior

When the user is expected to confirm transaction details on their Ledger, the correct detail should also be displayed on the Desktop Wallet.

Current Behavior

When sending a vote transaction, a modal stating "Awaiting Ledger Signature. Please check and sign the transaction when you are ready." is displayed. The user is asked to confirm the public key of the delegate they are voting for on their Ledger, which is not displayed in the Desktop Wallet anywhere.

Possible Solution

Change the "Awaiting Ledger Signature. Please check and sign the transaction when you are ready." modal to also include transaction details.

Steps to Reproduce (for bugs)

Context

Your Environment

@ghost
Copy link

ghost commented Feb 18, 2020

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@dav1app dav1app added the Status: Needs Investigation The issue needs more investigation before it can be verified and resolved. label Feb 21, 2020
@ghost
Copy link

ghost commented Feb 21, 2020

This issue or pull request needs further investigation. Please wait for further information, thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Needs Investigation The issue needs more investigation before it can be verified and resolved.
Projects
None yet
Development

No branches or pull requests

4 participants