Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: missing error handling when resending transactions #1752

Closed
dated opened this issue Mar 2, 2020 · 2 comments
Closed

refactor: missing error handling when resending transactions #1752

dated opened this issue Mar 2, 2020 · 2 comments
Labels
Type: Refactor The pull request improves or enhances an existing implementation.

Comments

@dated
Copy link
Contributor

dated commented Mar 2, 2020

Resending an expired transaction fails while still showing a success message, the reason being that there is no error handling whatsoever in the respective modals emitResend method:

async emitResend () {
const shouldBroadcast = this.$store.getters['session/broadcastPeers']
await this.$client.broadcastTransaction(this.transaction.raw, shouldBroadcast)
this.$success(this.$t('TRANSACTION.RESENT_NOTICE', { transactionId: truncateMiddle(this.transaction.id) }))
this.$emit('close')
},

The respective functionality in the TransactionShow component should be refactored to use the same methods as the TransactionModal component.

@ghost
Copy link

ghost commented Mar 2, 2020

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@brenopolanski brenopolanski added the Type: Refactor The pull request improves or enhances an existing implementation. label Mar 4, 2020
@faustbrian
Copy link
Contributor

Closing, no longer relevant for 3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

No branches or pull requests

3 participants