This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Add StandardJS (closes #323) #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciorubeens
force-pushed
the
master
branch
3 times, most recently
from
db9ed65
to
2dff444
Compare
spresnal
approved these changes
Oct 11, 2017
| return this.click('[aria-label="Switch Network"] button') | ||
| .pause(500) | ||
| .click("//button[contains(text(), '"+network+"')]") | ||
| .click("//button[contains(text(), '" + network + "')]") |
There was a problem hiding this comment.
Is there an option in standardJS to enforce template literals?
fix
reviewed
Oct 14, 2017
| $scope = _$rootScope_.$new() | ||
| }) | ||
| }) | ||
| // beforeEach( () => { |
luciorubeens
added a commit
that referenced
this pull request
Oct 27, 2017
|
Merged manually! +5 👍🏻 |
bag-man
added a commit
to bag-man/ark-rpc
that referenced
this pull request
Oct 27, 2017
I saw that stardardJS was used here: ArkEcosystem/desktop-wallet#328 so figure it would be good to match that. This is currently not working due to the network connect middleware being ran in the wrong context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds StandardJS (#323) with the configuration for this project.
I've adapted the code under the
testfolder to that code style too. The rest of the code should be done incrementally because it is composed of a lot of different parts.