Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Use single AddressBookController for account view #338

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Use single AddressBookController for account view #338

merged 1 commit into from
Oct 24, 2017

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Oct 11, 2017

This is to fix initial add of contact. If you guys could test please, that'd be great!

Edit: to clarify, the issue is when a contact is first added to the client. Removing and re-adding doesn't work. Complete reset of data is required to replicate the issue (prior to my changes). After resetting the data, click on the "Add Contact" button in the left sidebar and add a new contact. It won't appear until a reload

@fix
Copy link

fix commented Oct 14, 2017

nice, also i have found tricky not to be able to rename a contact. I think that should be possible:

  • either deny rename if a contact with same name exists
  • either use a hidden id key in contact model so you can have same name for different contacts

I think first option should be ok (as contact name act as an identifier in the mind of users)

@alexbarnsley
Copy link
Member Author

No worries, I'll take a look! Shall I roll this into the same PR?

@fix
Copy link

fix commented Oct 14, 2017

yes make another PR, so we can reject the new one more easily, and still accept this one ;)

@alexbarnsley
Copy link
Member Author

I'll make another PR which will be so perfect, you couldn't possibly reject 😉

@luciorubeens luciorubeens merged commit 4a4cbe2 into ArkEcosystem:master Oct 24, 2017
@luciorubeens
Copy link
Contributor

+5!

@boldninja
Copy link
Member

@spresnal can you provide me with your Ark address - I'd like to give you a small token of appreciation for helping on providing your valuable input on a lot of these PRs and a mention in our monthly github blog post.

@alexbarnsley alexbarnsley deleted the bug/fix-initial-contact-creation branch November 2, 2017 21:22
@alexbarnsley
Copy link
Member Author

👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants