Theming#399

[aghArdeshir]

HI! This fixes issue #399 + minor theming tweaks

[j-a-m-l]

When I go to Appearance > Theme I can't see the themes.

I see an error on the console (you can open it with Ctrl+D): ReferenceError: vShare is not defined

[spresnal]

Should probably remove the commented out code here

[aghArdeshir]

Thanks @spresnal . But setting theme's name before registering it caused a lot of extra watches. watching themes and colors in angularJS Material is so expensive and inefficient

BTW, Thanks for your hint, I made some other changes, if they didn't fix it, I'll revert them. (just preserving the main fix commit)

THanks :)

[aghArdeshir]

@j-a-m-l Thanks for your review. I actually couldn't find out what the error you told me was about : ReferenceError: vShare is not defined
that vShare I think is an iOS thing. I'm not sure what that was about and I couldn't reproduce it, but yeah, my commits caused more issues. I added two more commits. Please check if what you did happens with these new commits.
Or if possible please tell me how to reproduce the issue . Thanks : )

BTW,that vShare .. were you thinking `bout something else while writing that review ? : )

[j-a-m-l]

The vShare problem was exclusive of my environment: my app/dependencies.min.js wasn't correctly generated by npm run bundle.

[fix]

i have the vshare issue here with latest from master, on macOs

[fix]

@j-a-m-l did you fix the vshare issue?

[aghArdeshir]

@fix I couldn't reproduce issue. So I, no! Didn't

[j-a-m-l]

I haven't had that vShare problem again.

[boldninja]

@Ardeshir81 can you provide me with your ARK address?

[aghArdeshir]

@boldninja yeah . can I ask why ? do you want it here ? or somewhere else ?

[boldninja]

@Ardeshir81 you can contact me on Slack if you don't want it public. Its to receive github bounty.

[aghArdeshir]

Thank you @boldninja . I'll contact you in slack