This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: prevent duplicate profile name #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ProfileEdition page, errors were shown when entering dulplicate/invalid/empty profile names. But user wasn't prevented from saving them. User is not allowed to toggle off profile name, until it is free of errors, which in turn prevents saving of edits to the profile.
|
I don't understand the fix here. If i edit a profile name and change it to a name that already exists, i'm not able to finish editing the name, or press the save button. I just tested this and that is how it's working. Testing your PR gave me no difference. Can you do a before and after gif/video to show the issue please. |
|
@alexbarnsley https://www.youtube.com/watch?v=TQbfx4rNDGg (before) With this PR, enter/esc button can't be used to toggle if profile name has a duplicate |
alexbarnsley
approved these changes
Dec 12, 2018
alexbarnsley
pushed a commit
that referenced
this pull request
Dec 14, 2018
* Remove whitespace at top of WalletSidebar.vue with pt-0 in root component
* wrap routerlink in div with redirect('dashboard')
* fix create/import wallet alignment with align: center; (on each) and reformat padding on parents
* rebase against develop
* move NetworkOverview from Settings to Network SideMenuItem
* ButtonReload now inline-flex to accomodate all its uses
* Unselect from appsidemenu when logo clicked
* Fix spacing issue with NetworkStatus pop-aside Network Overview and Connect your peer buttons
* refactor: add avatar profile "more" icon (#701)
* refactor: add avatar profile dots
* fix: position on small height
* make self-stretch great once more
* feat : display helper text when known address is recognized (#687)
* fix: set screenshot protection upon app launch instead of sidebar (#705)
* feat: add message for insufficient balance in other tx types (#692)
* misc: improve the GitHub bug report template (#706)
* chore: remove yarn installation from circleci (#703)
* Separate Network pop-aside in 2
* chore: update Vue and Babel related dependencies (#708)
* fix: keyup events on profile creation (#709)
When editing the profile name, keyup events (enter, esc keys) were not working. It didn't allow user to close the input. Thus, disabling the 'Save' button.
Thus there was no way user could edit their profile name.
* fix: go to wallet list on ledger disconnect (#711)
* fix: ledger transaction expiry (#710)
* fix: show ledger transactions no dashboard
* fix: correct use/storage of profile id
* fix: sync watch ledger for new transactions
* test: fix failing
* fix: don't update ledger wallet with txs
* fix: check correctly if the balance is enough for creating the second signature (#714)
* fix: do not throw an Error when closing `TransactionShow` (#713)
* Bugfix : Validation after after regenerating 2nd passphrase (#712)
* Add minimum fee notice (#704)
* fix: replace deprecated qrcode package (#707)
* fix: prevent duplicate profile name (#715)
* refactor: improve network button padding
zillionn
pushed a commit
to zillionn/desktop-wallet
that referenced
this pull request
Dec 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ProfileEdition page, errors were shown when entering dulplicate/invalid/empty profile names. But user wasn't prevented from saving them.
Proposed changes
User is not allowed to toggle off profile name, until it is free of errors, which in turn prevents saving of edits to the profile.
Types of changes
Checklist