Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show tx notifications for contacts #915

Merged
merged 3 commits into from Dec 31, 2018

Conversation

@ItsANameToo
Copy link
Collaborator

commented Dec 31, 2018

Proposed changes

Transaction notifications would also show for contacts, which it shouldn't do

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
translation: 'SYNCHRONIZER.NEW_SECOND_SIGNATURE',
options: {
address: truncateMiddle(wallet.address)
if (!wallet.isContact) {

This comment has been minimized.

Copy link
@alexbarnsley

alexbarnsley Dec 31, 2018

Member

I think instead of all the indenting, just do the below at the top:

if (wallet.isContact) {
  return
}

@alexbarnsley alexbarnsley merged commit d7dc12d into develop Dec 31, 2018

1 check passed

ci/circleci: test-node-9 Your tests passed on CircleCI!
Details

@alexbarnsley alexbarnsley deleted the fix/contact-tx-notification branch Dec 31, 2018

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 9, 2019

fix: do not show tx notifications for contacts (ArkEcosystem#915)
* fix: do not show tx notifications for contacts

* fix: return if wallet is contact instead of indenting

PHANTOM-DEV1 added a commit to PhantomChain/desktop-wallet that referenced this pull request Jan 17, 2019

fix: do not show tx notifications for contacts (ArkEcosystem#915)
* fix: do not show tx notifications for contacts

* fix: return if wallet is contact instead of indenting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.