Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: the network settings was partially hidden when using a letter avatar #980

Merged
merged 4 commits into from Jan 17, 2019
Merged

fix: the network settings was partially hidden when using a letter avatar #980

merged 4 commits into from Jan 17, 2019

Conversation

j-a-m-l
Copy link
Contributor

@j-a-m-l j-a-m-l commented Jan 16, 2019

Proposed changes

When using a letter avatar the network settings are not completely displayed.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@j-a-m-l j-a-m-l changed the title fix: the floating position of the network settings fix: the network settings was partially hidden when using a letter avatar Jan 16, 2019
@j-a-m-l j-a-m-l added Status: Needs Review The issue or pull request needs a review by a developer of the team. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jan 16, 2019
@codecov-io
Copy link

codecov-io commented Jan 16, 2019 •
edited

Codecov Report

Merging #980 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #980   +/-   ##
========================================
  Coverage    38.58%   38.58%           
========================================
  Files          198      198           
  Lines         4903     4903           
  Branches       958      961    +3     
========================================
  Hits          1892     1892           
  Misses        2893     2893           
  Partials       118      118
Impacted Files Coverage Δ
...components/App/AppSidemenu/AppSidemenuSettings.vue 0% <ø> (ø) ⬆️
...nents/App/AppSidemenu/AppSidemenuNetworkStatus.vue 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5471c22...b399ca4. Read the comment docs.

@luciorubeens luciorubeens merged commit c145851 into develop Jan 17, 2019
@luciorubeens luciorubeens deleted the fix-network-settings-postion branch January 17, 2019 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luciorubeens luciorubeens luciorubeens approved these changes

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

Assignees
No one assigned
Labels
Status: Needs Review The issue or pull request needs a review by a developer of the team. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j-a-m-l @codecov-io @luciorubeens