(failed) attempt to make the results remain until a new search is run #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
marianogoldman
commented
Nov 3, 2020
| @@ -27,6 +27,8 @@ final class SearchPage extends Component | |||
|
|
|||
| private ?LengthAwarePaginator $results = null; | |||
There was a problem hiding this comment.
@faustbrian This property cannot be made public (and hence have LiveWire rehydrate it on each request, at the cost of a larger payload off course). So we have no other option than to run the search again. Which I think it's a waste of time, given we still expect the user to enter other details in other fields before the search makes sense.
marianogoldman
commented
Nov 3, 2020
| @@ -23,15 +23,15 @@ | |||
|
|
|||
| @if($results && $results->count()) | |||
| <div> | |||
| @if ($state['type'] === 'block') | |||
There was a problem hiding this comment.
This was an attempt to re-render not based on current selection (which is being updated), but on latest search results. Of course it doesn't work, because $results didn't keep state.
Base automatically changed from
CU-2h2vay_Defer-property-updates-in-search-component
to
develop
November 4, 2020 01:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist