refactor: compact tables #668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsANameToo
reviewed
Dec 3, 2020
|
|
||
| public static function usesCompactTables(): bool | ||
| { | ||
| return static::compactTables() === true; |
There was a problem hiding this comment.
wot why, it already returns a boolean
ItsANameToo
reviewed
Dec 3, 2020
| @@ -1,8 +1,8 @@ | |||
| @if(isset($isSent)) | |||
| <span class="px-2 py-1 font-bold border rounded whitespace-nowrap text-theme-danger-400 border-theme-danger-100 dark:border-theme-danger-400"> | |||
| <span class="{{ ($compact ?? false) ? '' : 'px-2 py-1 border rounded border-theme-danger-100 dark:border-theme-danger-400' }} font-bold whitespace-nowrap text-theme-danger-400"> | |||
There was a problem hiding this comment.
this could be done with classes, moving the specific stuff out to a css file and having it apply on regular tables but not compact tables
…rer.ark.io into feat/condensed-tables
|
@Highjhacker please check #670 and work on that branch to finish the tables |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/awx21d
Checklist