fix: homepage stats chart size #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsANameToo
requested review from
alexbarnsley,
faustbrian and
samharperpittam
as code owners
ItsANameToo
commented
May 28, 2021
| @@ -49,8 +48,8 @@ class="ml-6" | |||
| x-init="init" | |||
| @toggle-dark-mode.window="toggleDarkMode" | |||
| > | |||
| <div class="block" wire:ignore style="width: 120px; height: 40px;"> | |||
There was a problem hiding this comment.
@alfonsobries I removed these instances as they didn't seem to do anything, did you have any reason to add them on both the divs?
samharperpittam
approved these changes
May 28, 2021
leMaur
reviewed
May 28, 2021
| @@ -49,8 +48,8 @@ class="ml-6" | |||
| x-init="init" | |||
| @toggle-dark-mode.window="toggleDarkMode" | |||
| > | |||
| <div class="block" wire:ignore style="width: 120px; height: 40px;"> | |||
| <canvas x-ref="chart" class="w-full h-full" ></canvas> | |||
| <div class="block" wire:ignore> | |||
There was a problem hiding this comment.
a div is a block by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This sets the chart dimensions directly on the canvas itself, otherwise it would end up out-of-bounds on retina displays
Checklist