Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: price stats section padding adjustment #814

Merged
merged 11 commits into from Jun 9, 2021

Conversation

alfonsobries
Copy link
Member

@alfonsobries alfonsobries commented Jun 8, 2021

Summary

https://app.clickup.com/t/3uwpvx

As the ticket explains there is a minor difference between the top padding and the bottom padding on the price stats section, the issue was related to the size of the navbar that should be 84px and should be 82px

This PR adjust the navbar size to ensure everything keeps aligned correctly

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo
Copy link
Member

@alfonsobries the navbar is supposed to be 84px in height, so if it's different in the design then the design is incorrect

@ItsANameToo
Copy link
Member

@alfonsobries I don't see anything about the navbar in the clickup task you linked 🤔 (https://app.clickup.com/t/m59ftw)

@ItsANameToo ItsANameToo marked this pull request as draft June 9, 2021 07:49
@alfonsobries
Copy link
Member Author

@ItsANameToo oops wrong link https://app.clickup.com/t/3uwpvx even with the 84px the margin below the navbar needs to be adjusted (it's cropping like 2px from the status section). Im on it

@alfonsobries
Copy link
Member Author

@ItsANameToo

@alfonsobries alfonsobries marked this pull request as ready for review June 9, 2021 14:20
@ItsANameToo ItsANameToo merged commit cfcec5b into deps-and-padding Jun 9, 2021
@ItsANameToo ItsANameToo deleted the fix/navbar-size branch June 9, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants