-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update currency tooltips when currency is changed #845
feat: update currency tooltips when currency is changed #845
Conversation
It looks good to me! 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfonsobries - Can you check something on this PR for me please? Think i've found an issue but it may be indirectly caused by this PR.
If you go to the following URL /wallets/DFyLKkWs12QwDTi8BywQN5ssa5CMK3dr6d
and then change the currency within the navbar.
Do the icons in the tx history table get messed up for you?
…o feat/update-currency-stuff-when-changed
…ArkEcosystem/explorer.ark.io into feat/update-currency-stuff-when-changed
@samharperpittam ✅ fixed |
@alfonsobries would it be possible to refresh the tooltips without having the whole table go into a loading state? feels odd to see the full table reload when the currency changes as it doesn't affect anything that's visible in the table at that point, or is it me @samharperpittam 🤔 |
@ItsANameToo yeah probably possible. Ill work on that right now |
…o feat/update-currency-stuff-when-changed
@ItsANameToo thought the change related to the skeleton would be very easy but it wasn't Since the skeleton is needed for the pagination OR for when we update the filter the solution is to find a way to show the skeleton conditionally, unfortunately, I didn't find a way an I tried a lot of alternatives. For example, I tried to add a flag to "disable" the skeleton but if I update the flag that triggers an update, and livewire shows the skeleton so I am running on circles here. Other alternatives I can think means changing the current implementation of the skeleton (make a JS only skeleton for example) but that means a big refactor, maybe for another PR |
…o feat/update-currency-stuff-when-changed
let's leave it as-is then @alfonsobries . We can recheck this if we get complains from users as it's limited to changing the currency and generally you don't change that every 2 minutes anyway |
@alfonsobries conflicts |
…o feat/update-currency-stuff-when-changed
Summary
https://app.clickup.com/t/mf6y1q
When the currency is updated on the navbar, it updates:
Checklist