fix: prevent amount to be truncated on transactions headers

[alfonsobries]

Summary

https://app.clickup.com/t/mfbyf4

Refactor the headers for the transactions that have amounts to prevent the amounts to be truncated.

To test:

You can use this transaction that have a large amount /transactions/3bebe1af7558b8ad94c873e951a0d156ab82941da27b85c6a3e1e9226cf5b106

Also, you can open one transaction per type by filtering on the home page and opening one per type. Is not easy to find transactions with large amounts so for testing purposes you can hardcode a random amount on the app/ViewModels/TransactionViewModel.php amount() method

Checklist

• Documentation (if necessary)
• Tests (if necessary)
• Ready to be merged

[alexbarnsley]

would it make more sense to reverse this, or reducing it completely until there are more "amount" types? 🤔

    public function hasAmount(): bool
    {
        if ($this->isTransfer()) {
            return true;
        }

        if ($this->isMultiPayment()) {
            return true;
        }

        return false;
    }

or

    public function hasAmount(): bool
    {
        return $this->isTransfer() || $this->isMultiPayment();
    }

[alfonsobries]

@alexbarnsley by checking the views that don't have the amount I was able to securely say which types don't have the amount, the rest of them used the fallback view and includes other types like "second signature", IPFS, etc. In other words, those types are the ones that have a special template so it's safest to exclude them. (In case you are wondering I tested the condition you proposed and even that the test pass some views are broken)

Regarding the multiline, it was in purpose to ensure the code coverage covers all the conditions

[ItsANameToo]

@alfonsobries can you add a comment regarding that to the code so the next guy doesn't go and refactor this without prior knowledge

[ItsANameToo]

@alfonsobries can you add a comment regarding that to the code so the next guy doesn't go and refactor this without prior knowledge