Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: push the generation of a vote report to the queue #882

Merged
merged 4 commits into from
Jul 14, 2021

Conversation

crnkovic
Copy link
Contributor

@crnkovic crnkovic commented Jul 13, 2021

Summary

https://app.clickup.com/t/mz7m2y

The CLI command previously did not push the GenerateVoteReport job to the queue, which made it run in an existing lifecycle when scheduler is ran. Due to the fact that the vote generation can take quite some time, I assume the command could fail and app would terminate, resulting in a bash script not running to completion.

Disclaimer

Laravel Horizon is currently configured (and its corresponding queue connection) to timeout after 90s. If the job takes more than that, the job would fail with MaxAttemptsExceededException. As discussed in the ClickUp task, as there are no metrics how long the script takes on average, we agreed to just push it to the queue then act on it (increase the timeout) if we receive an error that the script has taken too long. In that case, we don't have to reconfigure the queue if the script takes less than that.

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@leMaur leMaur self-assigned this Jul 13, 2021
@ItsANameToo ItsANameToo changed the title Fix: Push the generation of a vote report to the queue fix: push the generation of a vote report to the queue Jul 13, 2021
@ItsANameToo ItsANameToo merged commit db70690 into develop Jul 14, 2021
@ItsANameToo ItsANameToo deleted the fix/vote-report-not-dispatching-to-queue branch July 14, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants