Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #929

Closed
wants to merge 23 commits into from
Closed

chore: update deps #929

wants to merge 23 commits into from

Conversation

leMaur
Copy link
Contributor

@leMaur leMaur commented Sep 23, 2021

Summary

https://app.clickup.com/t/12pgr17
depends on ArkEcosystemArchive/laravel-ui#662

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link
Member

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • dropdowns have issues with the arrow
    image
    image

@ItsANameToo ItsANameToo marked this pull request as draft September 23, 2021 10:29
@leMaur leMaur marked this pull request as ready for review September 23, 2021 15:26
@ItsANameToo
Copy link
Member

@leMaur still have the issue with the dropdowns. The workflow seems to recompile the assets as yours are different. Do you have any local changes that are not pushed or made to vendor files?

@ItsANameToo ItsANameToo marked this pull request as draft September 23, 2021 17:37
@leMaur
Copy link
Contributor Author

leMaur commented Sep 24, 2021

@leMaur still have the issue with the dropdowns. The workflow seems to recompile the assets as yours are different. Do you have any local changes that are not pushed or made to vendor files?

It seems linked to a change I did on UI. I'll double check...

@leMaur
Copy link
Contributor Author

leMaur commented Sep 24, 2021

@ItsANameToo need to adjust rich-select on UI and now I'm able to adjust the margin to tweak the button.

image

# Conflicts:
#	tests/Unit/Aggregates/ForgedAmountsAggregateTest.php
#	tests/Unit/Aggregates/ForgedFeesAggregateTest.php
#	tests/Unit/Aggregates/ForgedRewardsAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Average/DayAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Average/MonthAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Average/QuarterAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Maximum/DayAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Maximum/MonthAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Maximum/QuarterAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Minimum/DayAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Minimum/MonthAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Minimum/QuarterAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Minimum/RangeAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Minimum/WeekAggregateTest.php
#	tests/Unit/Services/Transactions/Aggregates/Fees/Minimum/YearAggregateTest.php
@ItsANameToo
Copy link
Member

@leMaur conflicts

leMaur and others added 3 commits September 28, 2021 08:35
# Conflicts:
#	app/Jobs/CacheVoterCountByPublicKey.php
#	public/js/app.js
#	public/mix-manifest.json
@leMaur
Copy link
Contributor Author

leMaur commented Sep 28, 2021

@ItsANameToo ✅ - I'll keep in draft until ArkEcosystemArchive/laravel-ui#662 will be merged.

@leMaur leMaur closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants