Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize cache-fees command #933

Merged
merged 7 commits into from
Sep 23, 2021
Merged

perf: optimize cache-fees command #933

merged 7 commits into from
Sep 23, 2021

Conversation

ItsANameToo
Copy link
Member

@ItsANameToo ItsANameToo commented Sep 23, 2021

Summary

https://app.clickup.com/t/1je17f5

This optimizes the cache-fees command in a similar fashion to #932 . It also removes obsolete min/avg/max aggregates for historic fees and changes the min/avg/max transaction values to use a single query

The fee aggregate methods may be obsolete now, will add a card to double check that later

Brings down execution time for the explorer:cache-fees command from 1m15s to 8s on my machine :hide:

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo
Copy link
Member Author

follow up card for fee aggregate factory checks: https://app.clickup.com/t/1jkqyqx

@ItsANameToo ItsANameToo changed the title perf: optimize cache-fees jobs perf: optimize cache-fees command Sep 23, 2021
@ItsANameToo ItsANameToo merged commit 3393d60 into develop Sep 23, 2021
@ItsANameToo ItsANameToo deleted the perf/cache-fees branch September 23, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant