Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize delegate resignation ids command #949

Merged
merged 4 commits into from
Sep 28, 2021

Conversation

leMaur
Copy link
Contributor

@leMaur leMaur commented Sep 27, 2021

Summary

https://app.clickup.com/t/1hk214j

from ⬇️

image

to ⬇️

image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alfonsobries alfonsobries self-assigned this Sep 27, 2021
Copy link
Member

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I clear my cache and then run the delegate caching commands I get a Missing required parameter for [Route: transaction] [URI: transactions/{transaction}] [Missing parameter: transaction]. error when trying to go to the resigned delegates tab.

Meanwhile it's fine on develop when I run the php artisan explorer:cache-delegate-wallets and php artisan explorer:cache-delegate-resignation-ids commands

@ItsANameToo ItsANameToo marked this pull request as draft September 28, 2021 08:40
@ItsANameToo ItsANameToo marked this pull request as ready for review September 28, 2021 09:01
@ItsANameToo ItsANameToo merged commit f5e9a6e into develop Sep 28, 2021
@ItsANameToo ItsANameToo deleted the perf/cache-delegate-resignation-ids branch September 28, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants