Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update page metadata #951

Merged
merged 9 commits into from
Sep 28, 2021
Merged

refactor: update page metadata #951

merged 9 commits into from
Sep 28, 2021

Conversation

leMaur
Copy link
Contributor

@leMaur leMaur commented Sep 27, 2021 •
edited
Loading

Summary

https://app.clickup.com/t/1fmacu0

Add metadata for pages:

  • home
  • statistics
  • delegates
  • transactions
  • blocks
  • wallets
  • search
  • 404

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@leMaur leMaur marked this pull request as ready for review September 27, 2021 16:32
ItsANameToo
ItsANameToo requested changes Sep 28, 2021
View reviewed changes
resources/views/components/metadata.blade.php Outdated Show resolved Hide resolved
resources/lang/en/metatags.php Outdated Show resolved Hide resolved
resources/lang/en/metatags.php Outdated Show resolved Hide resolved
resources/lang/en/metatags.php Outdated Show resolved Hide resolved
resources/lang/en/metatags.php Outdated Show resolved Hide resolved
resources/lang/en/metatags.php Outdated Show resolved Hide resolved
resources/lang/en/metatags.php Outdated Show resolved Hide resolved
resources/lang/en/metatags.php Outdated Show resolved Hide resolved
@ItsANameToo ItsANameToo marked this pull request as draft September 28, 2021 08:15
@leMaur leMaur marked this pull request as ready for review September 28, 2021 08:37
@ItsANameToo ItsANameToo changed the title refactor: add metadata refactor: update page metadata Sep 28, 2021
@ItsANameToo ItsANameToo merged commit fff4e00 into develop Sep 28, 2021
@ItsANameToo ItsANameToo deleted the refactor/update-meta-tags branch September 28, 2021 08:43
@faustbrian faustbrian mentioned this pull request Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

@faustbrian faustbrian Awaiting requested review from faustbrian

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leMaur @ItsANameToo