-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cache delegate performance command #953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsobries
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
samharperpittam
as code owners
September 27, 2021 17:56
…cosystem/explorer.ark.io into refactor/cache-delegate-performance
…o refactor/cache-delegate-performance
Draft while I test the ranges are correct |
ready to be tested ✅ |
…cosystem/explorer.ark.io into refactor/cache-delegate-performance
leMaur
approved these changes
Sep 29, 2021
ItsANameToo
requested changes
Sep 30, 2021
@ItsANameToo ok this is ready, I think that the old implementation was incorrect not only in the range limit but also was using incorrect ranges so I recommend to test this carefully |
…cosystem/explorer.ark.io into refactor/cache-delegate-performance
4 tasks
ItsANameToo
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/1hk1zw6
As with other similar tasks, it refactors the command to get all the data in a single query,
for the moment it returns the exact same results the old implementation used to return but think there is a bug with the ranges (but need some help) see slack discussionUpdate: this PR also fixes the ranges since the old implementation was adding an extra item to the range
To test:
Ensure the calculation is correct
Passed from 127.34s to 6.58s
Checklist