Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cache delegate performance command #953

Merged
merged 37 commits into from
Oct 15, 2021

Conversation

alfonsobries
Copy link
Member

@alfonsobries alfonsobries commented Sep 27, 2021

Summary

https://app.clickup.com/t/1hk1zw6

As with other similar tasks, it refactors the command to get all the data in a single query, for the moment it returns the exact same results the old implementation used to return but think there is a bug with the ranges (but need some help) see slack discussion

Update: this PR also fixes the ranges since the old implementation was adding an extra item to the range

To test:

Ensure the calculation is correct

Passed from 127.34s to 6.58s

image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alfonsobries alfonsobries marked this pull request as draft September 28, 2021 14:51
@alfonsobries
Copy link
Member Author

Draft while I test the ranges are correct

@alfonsobries
Copy link
Member Author

ready to be tested ✅

@alfonsobries alfonsobries marked this pull request as ready for review September 28, 2021 15:19
@leMaur leMaur self-assigned this Sep 29, 2021
@ItsANameToo ItsANameToo marked this pull request as draft September 30, 2021 15:49
@alfonsobries
Copy link
Member Author

@ItsANameToo ok this is ready, I think that the old implementation was incorrect not only in the range limit but also was using incorrect ranges so I recommend to test this carefully

@alfonsobries alfonsobries marked this pull request as ready for review October 4, 2021 16:32
@ItsANameToo ItsANameToo merged commit 02e0b21 into develop Oct 15, 2021
@ItsANameToo ItsANameToo deleted the refactor/cache-delegate-performance branch October 15, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants