Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update models and tests #78

Merged
merged 3 commits into from
Feb 10, 2020
Merged

refactor: update models and tests #78

merged 3 commits into from
Feb 10, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Feb 10, 2020

Summary

Updates the datatypes and tests to reflect the current development state, closes #57.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Feb 10, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Feb 10, 2020
@dated dated mentioned this pull request Feb 10, 2020
3 tasks
@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Feb 10, 2020
@ghost
Copy link

ghost commented Feb 10, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit a765c2e into ArkEcosystem:master Feb 10, 2020
@ghost
Copy link

ghost commented Feb 10, 2020

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Feb 10, 2020
@ghost
Copy link

ghost commented Feb 10, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the refactor/models branch February 10, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: High More than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update certain numeric values to strings
2 participants