Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 2.6 endpoints #79

Merged
merged 15 commits into from
Feb 10, 2020
Merged

feat: add 2.6 endpoints #79

merged 15 commits into from
Feb 10, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Feb 10, 2020

Summary

Adds the following API endpoints

GET

  • bridgechains
  • bridgechains/{id}
  • businesses
  • businesses/{id}
  • businesses/{id}/bridgechains
  • wallets/{id}/locks
  • locks
  • locks/{id}

POST

  • businesses/search
  • bridgechains/search
  • locks/search
  • locks/unlocked

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Feb 10, 2020
@faustbrian
Copy link
Contributor

@dated conflicts

@faustbrian faustbrian marked this pull request as ready for review February 10, 2020 07:04
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Feb 10, 2020
@faustbrian faustbrian added the Bounty: Tier 3 Awarded for medium features, refactorings, improvements. This is valued at 50 USD. label Feb 10, 2020
@dated
Copy link
Contributor Author

dated commented Feb 10, 2020

@faustbrian resolved

@ghost
Copy link

ghost commented Feb 10, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Feb 10, 2020
@faustbrian faustbrian merged commit 8d1916a into ArkEcosystem:master Feb 10, 2020
@ghost
Copy link

ghost commented Feb 10, 2020

Your pull request has been merged and marked as tier 3. It will earn you $50 USD.

@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 10, 2020
@dated dated deleted the feat/2.6-endpoints branch February 10, 2020 07:54
@ghost ghost mentioned this pull request Feb 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

@kristjank kristjank Awaiting requested review from kristjank

Assignees
No one assigned
Labels
Bounty: Tier 3 Awarded for medium features, refactorings, improvements. This is valued at 50 USD. Complexity: Undetermined Needs specialized, in-depth review. Status: Contributor Approved The pull request has been approved by a contributor. Type: Feature The issue is a request for new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dated @faustbrian