chore: Fix broken link to the documentation #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasild
requested review from
alexbarnsley,
faustbrian,
kristjank and
spkjp
as code owners
faustbrian
reviewed
Nov 6, 2019
README.md
Outdated
|
|
||
| ## Security | ||
|
|
||
| If you discover a security vulnerability within this package, please send an e-mail to security@ark.io. All security vulnerabilities will be promptly addressed. | ||
|
|
||
| ## Credits | ||
|
|
||
| This project exists thanks to all the people who [contribute](../../contributors). | ||
| This project exists thanks to all the people who [contribute](./contributors). |
There was a problem hiding this comment.
This is intentionally ../.. as it goes through some internal routing of GitHub that eventually ends up at https://github.com/ArkEcosystem/go-crypto/graphs/contributors.
There was a problem hiding this comment.
Maybe that was the case in the past, but now there is no "internal" routing (whatever that could mean). It is a basic HTTP redirect:
$ curl --head https://github.com/ArkEcosystem/go-crypto/contributors
HTTP/1.1 302 Found
Status: 302 Found
Location: https://github.com/ArkEcosystem/go-crypto/graphs/contributors
...
We could also point the link directly to ./graphs/contributors.
There was a problem hiding this comment.
Changing to that is also fine.
Also simplify the link to the contributors, even though both variants work.
faustbrian
approved these changes
Nov 10, 2019
faustbrian
changed the title
ghost
deleted the
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplify the link to the contributors, even though both variants
work.