Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix broken link to the documentation #56

Merged
merged 2 commits into from Nov 10, 2019

Conversation

@vasild
Copy link
Contributor

vasild commented Nov 6, 2019

Also simplify the link to the contributors, even though both variants
work.

README.md Outdated

## Security

If you discover a security vulnerability within this package, please send an e-mail to security@ark.io. All security vulnerabilities will be promptly addressed.

## Credits

This project exists thanks to all the people who [contribute](../../contributors).
This project exists thanks to all the people who [contribute](./contributors).

This comment has been minimized.

Copy link
@faustbrian

faustbrian Nov 6, 2019

Contributor

This is intentionally ../.. as it goes through some internal routing of GitHub that eventually ends up at https://github.com/ArkEcosystem/go-crypto/graphs/contributors.

This comment has been minimized.

Copy link
@vasild

vasild Nov 6, 2019

Author Contributor

Maybe that was the case in the past, but now there is no "internal" routing (whatever that could mean). It is a basic HTTP redirect:

$ curl --head https://github.com/ArkEcosystem/go-crypto/contributors
HTTP/1.1 302 Found
Status: 302 Found
Location: https://github.com/ArkEcosystem/go-crypto/graphs/contributors
...

We could also point the link directly to ./graphs/contributors.

This comment has been minimized.

Copy link
@faustbrian

faustbrian Nov 6, 2019

Contributor

Changing to that is also fine.

This comment has been minimized.

Copy link
@vasild

vasild Nov 6, 2019

Author Contributor

Done.

Also simplify the link to the contributors, even though both variants
work.
@vasild vasild force-pushed the fix-doc-url branch from 431f39c to 053ba39 Nov 6, 2019
@faustbrian faustbrian changed the title Fix broken link to the documentation chore: Fix broken link to the documentation Nov 10, 2019
@faustbrian faustbrian merged commit 462b3de into master Nov 10, 2019
2 checks passed
2 checks passed
unit
Details
codeclimate All good!
Details
@ArkEcosystemBot ArkEcosystemBot deleted the fix-doc-url branch Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.