Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: maintenance #76

Merged
merged 1 commit into from Mar 10, 2020
Merged

chore: maintenance #76

merged 1 commit into from Mar 10, 2020

Conversation

sleepdefic1t
Copy link
Contributor

Summary

  • use double-quotes on script vars
  • use printf vs echo in scripts
  • exit provision script gracefully if 'cd' fails
  • use CommException and add print statements in python script
  • improve ark_main(void), remove extra comments, reduce var scope

Checklist

  • Ready to be merged

@sleepdefic1t
ci: maintenance
a539d2d 
- use double-quotes on script vars
- use printf vs echo in scripts
- exit provision script gracefully if 'cd' fails
- use CommException and add print statements in python script
- improve ark_main(void), remove extra comments, reduce var scope
@ghost ghost added the Complexity: Medium Less than 256 lines changed. label Mar 10, 2020
@faustbrian faustbrian changed the title ci: maintenance chore: maintenance Mar 10, 2020
@faustbrian faustbrian merged commit 95b03af into ArkEcosystem:develop Mar 10, 2020
@sleepdefic1t sleepdefic1t deleted the ci/maintenance branch March 10, 2020 18:41
@ghost ghost mentioned this pull request Mar 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Complexity: Medium Less than 256 lines changed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sleepdefic1t @faustbrian