Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: label legacy magistrate and AIP36 transaction types #668

Merged
merged 4 commits into from
Sep 15, 2020
Merged

feat: label legacy magistrate and AIP36 transaction types #668

merged 4 commits into from
Sep 15, 2020

Conversation

luciorubeens
Copy link
Contributor

Summary

Display correct labels for new transaction types.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Sep 10, 2020
@luciorubeens luciorubeens marked this pull request as ready for review September 12, 2020 13:58
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Sep 12, 2020
@ghost ghost mentioned this pull request Sep 13, 2020
Closed
clucasalcantara
clucasalcantara approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@clucasalcantara clucasalcantara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽
images

The update on the UI to display these new transaction types will be automatic somewhere or we gonna add it in another PR?

@faustbrian faustbrian changed the title feat: implement AIP36 transaction types feat: label legacy magistrate and AIP36 transaction types Sep 14, 2020
@luciorubeens luciorubeens merged commit 616c978 into master Sep 15, 2020
@luciorubeens luciorubeens deleted the refactor/aip36 branch September 15, 2020 12:13
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Sep 15, 2020
@ghost ghost mentioned this pull request Sep 20, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clucasalcantara clucasalcantara clucasalcantara approved these changes

Assignees
No one assigned
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luciorubeens @clucasalcantara