Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sign and verify messages #25

Merged
merged 4 commits into from
Aug 7, 2019
Merged

feat: sign and verify messages #25

merged 4 commits into from
Aug 7, 2019

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Aug 5, 2019

Implement message signing and verification.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Aug 5, 2019
@codecov-io
Copy link

codecov-io commented Aug 5, 2019

Codecov Report

Merging #25 into master will increase coverage by 5.39%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #25      +/-   ##
=========================================
+ Coverage    31.5%   36.9%   +5.39%     
=========================================
  Files           5       6       +1     
  Lines          73      84      +11     
  Branches        3       3              
=========================================
+ Hits           23      31       +8     
- Misses         50      53       +3
Impacted Files Coverage Δ
src/crypto.ts 0% <ø> (ø) ⬆️
src/router.ts 0% <0%> (ø) ⬆️
src/message.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1106f51...33510fb. Read the comment docs.

@ItsANameToo
Copy link
Member

ItsANameToo commented Aug 5, 2019

TODO:

  • responsiveness
  • homepage button solution; e.g. toggle or something similar

@ItsANameToo
Copy link
Member

@faustbrian take a look

@faustbrian faustbrian merged commit fe80f85 into master Aug 7, 2019
@ghost ghost deleted the feat/message branch August 7, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants