Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sign and verify messages #25

Merged
merged 4 commits into from Aug 7, 2019

Conversation

@faustbrian
Copy link
Contributor

commented Aug 5, 2019

Implement message signing and verification.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@faustbrian faustbrian force-pushed the feat/message branch from a6b2a3a to 297fbc0 Aug 5, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

Merging #25 into master will increase coverage by 5.39%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #25      +/-   ##
=========================================
+ Coverage    31.5%   36.9%   +5.39%     
=========================================
  Files           5       6       +1     
  Lines          73      84      +11     
  Branches        3       3              
=========================================
+ Hits           23      31       +8     
- Misses         50      53       +3
Impacted Files Coverage Δ
src/crypto.ts 0% <ø> (ø) ⬆️
src/router.ts 0% <0%> (ø) ⬆️
src/message.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1106f51...33510fb. Read the comment docs.

@ItsANameToo

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

TODO:

  • responsiveness
  • homepage button solution; e.g. toggle or something similar

ItsANameToo added some commits Aug 6, 2019

@ItsANameToo

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

@faustbrian take a look

@faustbrian faustbrian merged commit fe80f85 into master Aug 7, 2019

3 of 9 checks passed

security/snyk - third-party/angular-animate/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - third-party/angular-bootstrap/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - third-party/angular/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - third-party/html2canvas/package.json (ArkEcosystem) Manifest not found
Details
security/snyk - third-party/lato-font/Gemfile.lock (ArkEcosystem) Manifest not found
Details
security/snyk - third-party/lato-font/package.json (ArkEcosystem) Manifest not found
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: node-12 Your tests passed on CircleCI!
Details
security/snyk - package.json (ArkEcosystem) No manifest changes detected

@ArkEcosystemBot ArkEcosystemBot deleted the feat/message branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.