Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e tests for wallet pages #26

merged 3 commits into from Aug 12, 2019


Copy link

commented Aug 9, 2019

Adds E2E tests for the wallet pages and include some minor changes.


  • Prefixed wallet routes with /wallet
  • Fixed failing E2E tests for messages after latest UI changes

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@faustbrian faustbrian force-pushed the test/e2e-wallet branch from a4b0d18 to 452a5ce Aug 9, 2019

faustbrian added some commits Aug 9, 2019


This comment has been minimized.

Copy link

commented Aug 9, 2019

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #26   +/-   ##
  Coverage    36.9%   36.9%           
  Files           6       6           
  Lines          84      84           
  Branches        3       3           
  Hits           31      31           
  Misses         53      53
Impacted Files Coverage Δ
src/router.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55690e7...26bd395. Read the comment docs.

@faustbrian faustbrian merged commit bdd2066 into master Aug 12, 2019

3 of 9 checks passed

security/snyk - third-party/angular-animate/package.json (ArkEcosystem) Manifest not found
security/snyk - third-party/angular-bootstrap/package.json (ArkEcosystem) Manifest not found
security/snyk - third-party/angular/package.json (ArkEcosystem) Manifest not found
security/snyk - third-party/html2canvas/package.json (ArkEcosystem) Manifest not found
security/snyk - third-party/lato-font/Gemfile.lock (ArkEcosystem) Manifest not found
security/snyk - third-party/lato-font/package.json (ArkEcosystem) Manifest not found
Codacy/PR Quality Review Up to standards. A positive pull request.
ci/circleci: node-12 Your tests passed on CircleCI!
security/snyk - package.json (ArkEcosystem) No new issues

@ArkEcosystemBot ArkEcosystemBot deleted the test/e2e-wallet branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.