Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: progressive web app support (PWA) #29

Merged
merged 2 commits into from
Aug 26, 2019
Merged

feat: progressive web app support (PWA) #29

merged 2 commits into from
Aug 26, 2019

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Aug 22, 2019

Makes it possible to use the paper wallet offline by installing it as a local application through your browser.

PWAs only work over HTTPS @ItsANameToo. Easiest to run it is to locally do valet secure paper-wallet for testing to get a local SSL certificate.

Draft because I'm waiting for images from Oleg.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Aug 22, 2019
@codecov-io
Copy link

codecov-io commented Aug 22, 2019

Codecov Report

Merging #29 into master will increase coverage by 4.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage    36.9%   41.33%   +4.42%     
==========================================
  Files           6        5       -1     
  Lines          84       75       -9     
  Branches        3        3              
==========================================
  Hits           31       31              
+ Misses         53       44       -9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d351057...c6a13bd. Read the comment docs.

@faustbrian faustbrian marked this pull request as ready for review August 26, 2019 08:11
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Aug 26, 2019
@faustbrian faustbrian merged commit 1be16bb into master Aug 26, 2019
@ghost ghost deleted the pwa branch August 26, 2019 08:17
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants