Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add new test #33

Merged
merged 1 commit into from
Sep 17, 2019
Merged

test: add new test #33

merged 1 commit into from
Sep 17, 2019

Conversation

Pedro-Souza
Copy link
Contributor

Add new test for lifecycle mounted.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Sep 14, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality. labels Sep 14, 2019
@Pedro-Souza Pedro-Souza changed the title feat: add new test test: add new test Sep 14, 2019
faustbrian
faustbrian suggested changes Sep 15, 2019
View reviewed changes
Copy link
Contributor

@faustbrian faustbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording of the new test should be changed as suggested and all the extra nesting with describe should be reverted. Keep it to a single level.

tests/unit/views/Wallet.spec.ts Outdated Show resolved Hide resolved
@ghost ghost mentioned this pull request Sep 15, 2019
Closed
@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Sep 17, 2019
@ghost
Copy link

ghost commented Sep 17, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Sep 17, 2019
@faustbrian faustbrian merged commit e68c2f0 into ArkEcosystem:master Sep 17, 2019
@ghost
Copy link

ghost commented Sep 17, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@ghost ghost mentioned this pull request Sep 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

Assignees
No one assigned
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Feature The issue is a request for new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pedro-Souza @faustbrian