Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove psr dependencies #34

Merged
merged 5 commits into from Dec 18, 2018
Merged

refactor: remove psr dependencies #34

merged 5 commits into from Dec 18, 2018

Conversation

faustbrian
Copy link
Contributor

Proposed changes

The PSR packages made some updates which prevent the client from working under certain circumstances and it just adds overhead as the client is rather simple anyways and the types of users we have won't be swapping out implementations.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit 2341cc4 into master Dec 18, 2018
@faustbrian faustbrian deleted the develop branch December 18, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant