Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update guzzlehttp/guzzle & illuminate/support #92

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

repat
Copy link
Contributor

@repat repat commented Sep 16, 2020

Summary

What changes are being made?

Why are these changes necessary?

I would like to use this package with Laravel 8.X

$ composer require arkecosystem/client
Using version ^1.2 for arkecosystem/client
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Can only install one of: guzzlehttp/guzzle[7.0.1, 6.5.x-dev].
    - Can only install one of: guzzlehttp/guzzle[6.5.x-dev, 7.0.1].
    - Can only install one of: guzzlehttp/guzzle[6.5.x-dev, 7.0.1].
    - arkecosystem/client 1.2.0 requires guzzlehttp/guzzle ^6.5 -> satisfiable by guzzlehttp/guzzle[6.5.x-dev].
    - Installation request for arkecosystem/client ^1.2 -> satisfiable by arkecosystem/client[1.2.0].
    - Installation request for guzzlehttp/guzzle (locked at 7.0.1, required as ^7.0.1) -> satisfiable by guzzlehttp/guzzle[7.0.1].

How were these changes implemented?

Just updated the composer.json, composer install'ed and ran the tests with ./vendor/bin/phpunit

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Gone through the Guzzle Upgrade Guide and couldn't find any problems.

Left to do

  • Changelog
  • Create release

@ghost
Copy link

ghost commented Sep 16, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Low Less than 64 lines changed. label Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #92   +/-   ##
=========================================
  Coverage     90.84%   90.84%           
  Complexity       66       66           
=========================================
  Files            14       14           
  Lines           142      142           
=========================================
  Hits            129      129           
  Misses           13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3755cb...826f103. Read the comment docs.

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Sep 16, 2020
@ghost
Copy link

ghost commented Sep 16, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian added the Bounty: Tier 5 Awarded for minor features, refactorings, improvements. This is valued at 0 USD. label Sep 16, 2020
@faustbrian faustbrian changed the title Update guzzlehttp/guzzle & illuminate/support chore: update guzzlehttp/guzzle & illuminate/support Sep 16, 2020
@faustbrian faustbrian merged commit 12dd044 into ArkEcosystem:master Sep 16, 2020
@ghost
Copy link

ghost commented Sep 16, 2020

Your pull request has been merged. Thank you for your contribution to the ARK Ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 5 Awarded for minor features, refactorings, improvements. This is valued at 0 USD. Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants