Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Visual Studio and VS Code Support #48

Merged
merged 1 commit into from Aug 28, 2018

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Aug 27, 2018

Proposed changes

Added .vs and .vscode to the .gitignore file to support Visual Studio and VS Code

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe: Development environment support

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixes #47

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   79.48%   79.48%           
=======================================
  Files          39       39           
  Lines         697      697           
  Branches       70       70           
=======================================
  Hits          554      554           
  Misses        112      112           
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e7799...4557ad3. Read the comment docs.

@faustbrian faustbrian merged commit 1d1f52f into ArkEcosystem:master Aug 28, 2018
@faustbrian
Copy link
Contributor

@ciband Please start to follow the https://docs.ark.io/guidebook/contribution-guidelines/git-commit-guidelines.html guidelines. I always have to reword your commits before I merge them.

@ciband
Copy link
Contributor Author

ciband commented Aug 28, 2018

@faustbrian
Sorry about that. I completely missed the verb tense and case in the guidelines. We have slightly different guidelines for git in my day job. I will pay more attention going forward. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Microsoft Visual Studio and VS Code
4 participants