Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: available resources #95

Merged
merged 3 commits into from Feb 24, 2020
Merged

types: available resources #95

merged 3 commits into from Feb 24, 2020

Conversation

rigwild
Copy link
Contributor

@rigwild rigwild commented Feb 23, 2020

Summary

What changes are being made?

  • Implement typings for the API selection
  • Strictier sendRequest http method typings
  • Linting and // @ts-ignore cleanup

Why are these changes necessary?

Makes it easier to use the SDK. The current any typings on the api selection method makes it hard to know what functions are available.

See the following screenshots.
screenshot 35
screenshot 36

Checklist

  • Ready to be merged

@ghost
Copy link

ghost commented Feb 23, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Medium Less than 256 lines changed. label Feb 23, 2020
@faustbrian faustbrian changed the title Add API selection typings types: available resources Feb 24, 2020
@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Feb 24, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Feb 24, 2020
@faustbrian faustbrian merged commit 2bdf431 into ArkEcosystem:master Feb 24, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@rigwild rigwild deleted the ts-api-types branch February 24, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Medium Less than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants