Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESP32 Tests #157

Merged
merged 1 commit into from Oct 28, 2019
Merged

Fix ESP32 Tests #157

merged 1 commit into from Oct 28, 2019

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Oct 28, 2019

Summary

ESP32 test builds were not passing and the tests themselves were not
being compiled into the firmware binary. Added missing ignore filters
to ignore desktop libraries for building PIO and desktop targets in the
same source tree.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

ESP32 test builds were not passing and the tests themselves were not
being compiled into the firmware binary.  Added missing ignore filters
to ignore desktop libraries for building PIO and desktop targets in the
same source tree.
@ghost
Copy link

ghost commented Oct 28, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added the Complexity: Low Less than 64 lines changed. label Oct 28, 2019
@ciband ciband mentioned this pull request Oct 28, 2019
3 tasks
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #157 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #157   +/-   ##
========================================
  Coverage    97.92%   97.92%           
========================================
  Files            8        8           
  Lines          385      385           
========================================
  Hits           377      377           
  Misses           8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413be54...357b627. Read the comment docs.

@ghost
Copy link

ghost commented Oct 28, 2019

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Member Approved The pull request has been approved by a member. label Oct 28, 2019
@sleepdefic1t sleepdefic1t merged commit d480cb8 into develop Oct 28, 2019
@ghost
Copy link

ghost commented Oct 28, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@ghost ghost deleted the test/fix_esp32 branch October 28, 2019 20:44
@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Nov 1, 2019
@ghost
Copy link

ghost commented Nov 1, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Member Approved The pull request has been approved by a member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants