-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable esp8266 tests #158
Enable esp8266 tests #158
Conversation
ESP32 test builds were not passing and the tests themselves were not being compiled into the firmware binary. Added missing ignore filters to ignore desktop libraries for building PIO and desktop targets in the same source tree.
Split up and re-enabled ESP8266 tests. API tests required further splitting due to large amounts of strings.
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
@ciband There's also no longer a |
Codecov Report
@@ Coverage Diff @@
## develop #158 +/- ##
========================================
Coverage 97.92% 97.92%
========================================
Files 8 8
Lines 385 385
========================================
Hits 377 377
Misses 8 8 Continue to review full report at Codecov.
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
* test: Fix EPS32 test builds ESP32 test builds were not passing and the tests themselves were not being compiled into the firmware binary. Added missing ignore filters to ignore desktop libraries for building PIO and desktop targets in the same source tree. * test: Fix ESP8266 tests Split up and re-enabled ESP8266 tests. API tests required further splitting due to large amounts of strings.
* feat: wallets locks endpoint * refactor: add missing test * feat: add businesses endpoints * feat: add bridgechains endpoints * feat: add locks endpoints * fix: header files * fix: typo * fix: typo * Enable esp8266 tests (#158) * test: Fix EPS32 test builds ESP32 test builds were not passing and the tests themselves were not being compiled into the firmware binary. Added missing ignore filters to ignore desktop libraries for building PIO and desktop targets in the same source tree. * test: Fix ESP8266 tests Split up and re-enabled ESP8266 tests. API tests required further splitting due to large amounts of strings. * fix: various typos and missing declarations * fix: add new files to arduino * fix: typo * refactor: adjust unlocked post params * refactor: adjust mock signature
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
Summary
Split up and re-enabled ESP8266 tests. API tests required further
splitting due to large amounts of strings.
Requires #157 and a rebase, or close #157 and just merge this PR. However you want to break it up.
Checklist