Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase coverage #93

Merged
merged 2 commits into from
May 25, 2019
Merged

test: increase coverage #93

merged 2 commits into from
May 25, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Proposed changes

This PR primarily deals with improving test coverage.

Specifically, this PR does the following:

  • removes unnecessary methods in host class.
  • uses string instead of char* in Host::ip.
  • improves testing of host class.
  • improves testing of paths class.
  • updates connection test to use string.
  • improves testing of host class.
  • updates the change log.

Types of changes

  • Other... Please describe:

Improves class members and test coverage to 100%.

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

- remove unnecessary methods in `host` class.
- use string instead of char* in `Host::ip`.
- improve testing of `host` class.
- improve testing of `paths` class.
- update connection test to use string.
- improve testing of `host` class.
- update the change log.
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels May 24, 2019
@sleepdefic1t
Copy link
Contributor Author

@faustbrian
Looks like CircleCI is bugging out again.
This build task isn't in my CircleCI jobs,
and it doesn't look like it appears here either: circleci/ArkEcosystem

Passing tests here:
circleci/sleepdefic1t/cpp-client

100% CodeCov:
codecov/sleepdefic1t/cpp-client

@sleepdefic1t
Copy link
Contributor Author

gonna try something..

@codecov-io
Copy link

Codecov Report

Merging #93 into master will increase coverage by 3.59%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #93     +/-   ##
=======================================
+ Coverage    96.4%   100%   +3.6%     
=======================================
  Files          14     14             
  Lines         250    245      -5     
=======================================
+ Hits          241    245      +4     
+ Misses          9      0      -9
Impacted Files Coverage Δ
src/host/host.cpp 100% <100%> (+31.81%) ⬆️
src/api/paths.cpp 100% <0%> (+0.64%) ⬆️
src/http/os/http.cpp 100% <0%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63837f...b57d988. Read the comment docs.

@faustbrian faustbrian changed the title chore(coverage): improve tests cases test: increase coverage May 25, 2019
@faustbrian faustbrian merged commit 00e798b into ArkEcosystemArchive:master May 25, 2019
@sleepdefic1t sleepdefic1t deleted the test/improve-coverage branch July 3, 2019 17:13
This was referenced Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants