build(platformio): Improve PlatformIO Configuration #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current configuration of PlatformIO was incorrect and causes build files to be included in the search path. Particularly, external library dependency directories were included in their entirety. I became aware there was an issue at [cpp-crypto #100](#100) when AUnit released v.1.3. Specifically, this PR does the following: - configures PlatformIO to create build and dep dirs in a specific location out of the search path. - removes the now-uneeded `lib_ldf_mode` keys. - updates the `src_filter` keys. - adds a dummy prototype file for correct CI build tests. - updates the changelog. All changes are non-breaking.
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
ghost
added
the
|
The ci/circleci: build-linux-default job is failing as of 8cfdd2646b9dbbdd3077f4d6c078cd4e1ad2a717. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
The ci/circleci: build-linux-default job is failing as of 774e52a9c5cfc38ceff767d7edae8d118efae3bf. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
CI clones repos recursively. Git submodules are not used with PlatformIO. This commit empties git submodule folders for `linux-default`/PlatformIO CI builds.
Codecov Report
@@ Coverage Diff @@
## develop #101 +/- ##
========================================
Coverage 91.14% 91.14%
========================================
Files 27 27
Lines 836 836
========================================
Hits 762 762
Misses 74 74Continue to review full report at Codecov.
|
This was referenced Jun 20, 2019
faustbrian
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current configuration of PlatformIO is incorrect and causes build files to be included in the search path.
Particularly, external library dependency directories were included in their entirety.
I became aware there was an issue at #100 when AUnit released v.1.3.
Specifically, this PR does the following:
lib_ldf_modekeys.src_filterkeys.All changes are non-breaking.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
The PR fulfills these requirements:
developbranch, not themasterbranch