fix(transaction): Improve Numeric Json Serialization #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation sometimes fails to properly serialize numbers in the `toJson()` method. This is especially detrimental to some Linux builds and all Arduino IDE builds (Arduino IDE Library version (Cpp-Crypto-Arduino-v.0.3.0)). Specifically, this PR does the following: - moves `<cinttypes>` to `crypto_helpers.h` for non-IoT builds. - forces type serialization for: - `amount` (llu/uint64_t). - `fee` (llu/uint64_t). - `network` (uint8_t/int). - `timestamp` (lu/uint32_t). - `type` (uint8_t/int). - `version` (uint8_t/int). - updates the changelog.
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
ghost
added
Complexity: Low
|
The ci/circleci: build-linux-default job is failing as of c0a326fa0cf246c7734ad048423bb0e743c22c0d. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
1 similar comment
|
The ci/circleci: build-linux-default job is failing as of c0a326fa0cf246c7734ad048423bb0e743c22c0d. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
sleepdefic1t
changed the title
|
@faustbrian This is good to go 👍 |
faustbrian
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation sometimes fails to properly serialize numbers in the
toJson()method.This is especially an issue in some Linux builds and all Arduino IDE builds (Arduino IDE Library Manager version (Cpp-Crypto-Arduino-v.0.3.0)).
Specifically, this PR does the following:
<cinttypes>tocrypto_helpers.hfor non-IoT builds.amount(llu/uint64_t).fee(llu/uint64_t).network(uint8_t/int).timestamp(lu/uint32_t).type(uint8_t/int).version(uint8_t/int).This PR resolves #99.
Tests will fail until #101 is merged and this PR is rebased.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranch