Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(identities): improve implementation #120

Merged
merged 14 commits into from Aug 8, 2019
Merged

refactor(identities): improve implementation #120

merged 14 commits into from Aug 8, 2019

Commits on Jul 16, 2019

  1. chore: merge develop into master (#115)

    @faustbrian
    faustbrian committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    3b7df4c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. chore: setup probot/stale configuration (#117)

    @faustbrian
    faustbrian committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    ff9126d View commit details
    Browse the repository at this point in the history

  2. chore(readme): add lead maintainer information (#118)

    @faustbrian
    faustbrian committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    f02c6d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. refactor(identities): improve implementation 

    This PR is mostly centered around improving the Identities implementation.

Use of std::array replaces std::vector in many instances to avoid dynamic allocation. The result is a ~4x-6x gain in execution speed of relevant functions, and a reduced memory footprint overall.

Specifically, this PR does the following:
- refactors Identities classes.
- adds hash class.
- adds curve class.
- adds str helpers.
- adds base58 class.
- moves hex helpers.
- updates other classes to match changes.
- adds relevant tests.
- updates scrips, examples, documentation, and changelog.
    @sleepdefic1t
    sleepdefic1t committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    a591b58 View commit details
    Browse the repository at this point in the history

  2. fix: codacy/codefactor updates

    @sleepdefic1t
    sleepdefic1t committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    76692ce View commit details
    Browse the repository at this point in the history

  3. style(curve): remove white space

    @sleepdefic1t
    sleepdefic1t committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    81ce428 View commit details
    Browse the repository at this point in the history

  4. Update base58.cpp 

    codacy incorrectly analyzing header struct member as unused.
Not at all the case.
    @sleepdefic1t
    sleepdefic1t committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    7d38c54 View commit details
    Browse the repository at this point in the history

  5. fix(coverage): fix two misses.

    @sleepdefic1t
    sleepdefic1t committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    ba08eb5 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. misc cleanup. 

    trailing return, comments, naming, etc
    @sleepdefic1t
    sleepdefic1t committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    b0ddf8d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. Update address.cpp 

    remove redundant strlen check.
    @sleepdefic1t
    sleepdefic1t committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    025323b View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Update hex.cpp 

    testname helpers -> utils
    @sleepdefic1t
    sleepdefic1t committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    a08e2e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Merge remote-tracking branch 'upstream/develop' into refactor(identit… 

    …ies)/improve-implementation
    @sleepdefic1t
    sleepdefic1t committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    65d93e6 View commit details
    Browse the repository at this point in the history

  2. carry over improvement from #122

    @sleepdefic1t
    sleepdefic1t committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    aa6f1ec View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into refactor(identities)/improve-implementation

    @faustbrian
    faustbrian committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    9ae8656 View commit details
    Browse the repository at this point in the history