chore: merge develop into master #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Arduino IDE requires the use of a single true tab separator between the keyword name and identifier. When spaces are used rather than a true tab, the keyword is not highlighted. Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords
Current tests are ran in different orders per platform. This led to a modified global test custom_network being modified improperly. This PR properly handles that order variation by creating a local object to be modified. In future iterations, an AbstractNetwork will allow `const`.
Current implementation sometimes fails to properly serialize numbers in the `toJson()` method. This is especially detrimental to some Linux builds and all Arduino IDE builds (Arduino IDE Library version (Cpp-Crypto-Arduino-v.0.3.0)). Specifically, this PR does the following: - moves `<cinttypes>` to `crypto_helpers.h` for non-IoT builds. - forces type serialization for: - `amount` (llu/uint64_t). - `fee` (llu/uint64_t). - `network` (uint8_t/int). - `timestamp` (lu/uint32_t). - `type` (uint8_t/int). - `version` (uint8_t/int). - updates the changelog.
…#105) The current implementation only allows use with Devnet unless values are manually changed in `/src`. This PR enables network configuration via the public api. (Devnet, Mainnet, Testnet, and Custom Networks (bridgechains). Specifically this PR does the following: - Creates a Configuration class. - Creates Fee and Network Manager children for the Configuration class. - Allows passing a `Configuration to` Transaction Builder with a default value of `Devnet` & `StaticFees` (non-breaking). - Adds a FeePolicy-type. - Adds a Fee class (container for fee policies). - Adds a Networks class (container for preset networks). - Updates the TransactionTypes enum. - Improves the `Network` class and Network implementions. - Updates the `Slot` class to reflect changes (non-breaking). - Updates Transaction-related classes to reflect updates (non-breaking). - Adds tests for all changes. - Updates the Arduino IDE script. - Updates `.ino` Arduino sketches with Configuration examples. - Updates documentation with Configuration examples. - Updates the `keywords.txt` file to reflect changes. - Updates the changelog. - Updates version to `v.0.6.0`.
The current library manifest uses a wildcard `*` for the `platforms` value incorrectly signifying that it supports all platforms. This is incorrect as the Cpp SDK's only officially support the espressif8266 & espressif32 platforms. This PR corrects this discrepancy.
ghost
added
Complexity: Undetermined
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 87.28% 91.52% +4.24%
==========================================
Files 27 30 +3
Lines 739 861 +122
==========================================
+ Hits 645 788 +143
+ Misses 94 73 -21
Continue to review full report at Codecov.
|
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A summary of what changes this PR introduces and why they were made.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: