Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for Visual Studio 2019 #134

Closed
wants to merge 2 commits into from

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Aug 25, 2019

Updated CMakeSettings.json to support Visual Studio 2019 compilers and schema.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Aug 25, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Aug 25, 2019
@codecov-io
Copy link

Codecov Report

Merging #134 into develop will decrease coverage by 0.4%.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #134      +/-   ##
===========================================
- Coverage    91.82%   91.41%   -0.41%     
===========================================
  Files           33       30       -3     
  Lines          856      874      +18     
===========================================
+ Hits           786      799      +13     
- Misses          70       75       +5
Impacted Files Coverage Δ
src/include/cpp-crypto/transactions/transaction.h 66.66% <ø> (ø) ⬆️
src/transactions/transaction.cpp 89.41% <100%> (-0.12%) ⬇️
src/transactions/builder.cpp 76.81% <81.25%> (-0.34%) ⬇️
src/include/cpp-crypto/common/network.hpp 25% <0%> (-75%) ⬇️
src/managers/fee_manager.cpp 88.88% <0%> (-11.12%) ⬇️
src/transactions/deserializer.cpp 88% <0%> (-0.39%) ⬇️
src/include/cpp-crypto/common/configuration.hpp 100% <0%> (ø) ⬆️
src/common/network.cpp 100% <0%> (ø) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93022a8...9b1d06a. Read the comment docs.

@ghost
Copy link

ghost commented Aug 25, 2019

Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants