-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: Cleanup and Prep for Arduino IDE #64
misc: Cleanup and Prep for Arduino IDE #64
Conversation
misc: merge from upstream
- list ArduinoJson as a dependency. - add Arduino sketch path to config. - fix the 'platformio_example' path.
This reverts commit 55d830b.
use newest naming
- bcl - rfc6979 - stl - update header includes. - update CMakeLists.txts. - update Arduino Script to match changes.
@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
@sleepdefic1t Your pull request needs some changes. Please wait for a comment from one of our developers for more information. |
Also, why are we moving the docs into extras? I thought the normal pattern was to have docs at the top level directory. |
- also update Arduino script to match changes.
@sleepdefic1t The ci/circleci: build-linux-default job is failing as of bf803204cb9e941b93bcd3622edd10cc40bf8a4e. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
@ciband docs now only moved on Arduino builds 👍 |
This should be good to go now 👍 |
This PR broke Visual Studio support on Windows (CMakeSettings.json) as well as Windows CI support via Appveyor (.appveyor.yml). Do we still want to support Windows? |
@ciband Is this something you’d be interested in tackling? |
I can. We technically still have it as you can do cmake from the command line. That process is exactly the same across all platforms. We broke the nice visual studio integration by deleting the CMakeSettings.json. For Windows CI, I've been trying to get Ark to setup the Appveyor repo since the beginning of time. The .appveyor.yml file should be all that is needed once that account is setup. Someone from Ark will need to create the account and binding the GItHub repo to it (similar to Circle-CI). There was a long standing PR open on this that I think the stale bot closed. |
@ciband |
Proposed changes
This PR is cleanup prep for upcoming Arduino IDE branch.
It removes unnecessary files and moves others to a cleaner more Arduino-friendly layout.
It also properly configures
./library.json
to export packages correctly for external library managers.The following has been changed:
./appveyor.yml
../library.json
package export settings../test/travis.yml
../docs/
to./extras
in Arduino builds.cmake_example
../CMakeSettings.json
.uECC_README.md
.keywords.txt
../src/bcl
to./src/lib/
./src/rfc6979
to./src/lib/
./src/stl
to./src/lib/
ARDUINO_IDE.sh
script to reflectlib/
changes.All tests pass locally:
Types of changes
Checklist