Handle memo for function declarations / function assignments [publish]

[SukkaW]

Fixes #44

cc @ArnaudBarre

The PR also slightly improves matching performance by replacing Array#includes w/ Set#has (where the previous one is O(n) while the latter one is O(1)).

[ArnaudBarre]

Well JS perf is not as simple. For a long time for small sets it was faster to use arrays than Set, because they have been in the engine for a long time and more optimized. This seems to not be true anymore on V8, and the opposite on JSC where array seems unoptimized. perf link

Sadly set creation is still not optimized enough compare to array creation, so sets should not be created when use only a few times: perf link

Given the current status of engines, I think your change is good expect for the creation of allowExportNamesSet, because for most cases it will be undefined and this doesn't seem to have a short path in v8: perf link

For the feature side, I think we don't need to check that deep, something that looks like export default memo(Identifier) should be allowed, if the identifier is not a react component it will just fail at runtime and we don't need to handle that

[SukkaW]

Given the current status of engines, I think your change is good expect for the creation of allowExportNamesSet, because for most cases it will be undefined

I can do const allowExportNamesSet = allowExportNames ? new Set(allowExportNames) : undefined.

For the feature side, I think we don't need to check that deep, something that looks like export default memo(Identifier) should be allowed, if the identifier is not a react component it will just fail at runtime and we don't need to handle that

Hmmm, that makes sense. Identifier will always be named since it is an Identifier after all.

[ArnaudBarre]

Thanks for the PR, this is published in v0.4.9!