Improve Italian translations #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #, elixir-format | ||
| #: lib/listudy_web/templates/book/recommended.html.eex:1 | ||
| msgid "Chess Books" | ||
| msgstr "" | ||
| msgstr "Suggeriti da Gran Maestri" |
There was a problem hiding this comment.
@ArneVogel this and the following copy is where I had to swap the translations to make them meaningful, as explained in the PR description.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes extend and improve the previous Italian translations. Most of the translations were missing, likely because copies were simply not present at that time. Some typos have been fixed and sentences adjusted to make them sound more natural.
Please, note that in the template recommended.html.eex, the two
msgids"Grandmaster recommended"and"Chess Books"can not work in this order in Italian (and many other languages). To make the outcome meaningful, I had to swap the two translations (i.e."Grandmaster recommended"translated as"Chess Books", and vice versa). This is because the same sentence is split into two chunks displayed in a given order, which simply doesn't work.I strongly recommend introducing one single key (
"Grandmaster recommended Chess Books") and adjusting the template to shrink the title in a way the text is distributed over two lines (if this is really the wanted effect). Needless to say, all translations should be adapted after that.